Restore fetch test cases #1535
Merged
Restore fetch test cases #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://travis-ci.com/denoland/deno/jobs/170775382 |
|
Another failure on travis/mac https://travis-ci.com/denoland/deno/jobs/171240240 I will revert: #1543 |
ry
added a commit
to ry/deno
that referenced
this pull request
Jan 17, 2019
This reverts commit dd08165. These tests are still flaky: https://travis-ci.com/denoland/deno/jobs/171240240 https://travis-ci.com/denoland/deno/jobs/170775382
ry
added a commit
that referenced
this pull request
Jan 17, 2019
This reverts commit dd08165. These tests are still flaky: https://travis-ci.com/denoland/deno/jobs/171240240 https://travis-ci.com/denoland/deno/jobs/170775382
|
Maybe I'm missing something, but above links don't seem pointing the test failures to me... And I couldn't find any relevant failures in recent master's builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to restore some test cases of
fetch. I addedawaitof full response from the server.I'm not sure how flaky it was, but I checked this change passes in appveyor several times 1 2 3 4 5